From eadcf345669eb3aaf3185631e435556b8cf19a54 Mon Sep 17 00:00:00 2001 From: Iustin Pop Date: Wed, 11 Dec 2019 21:30:12 +0100 Subject: [PATCH] Remove obsolete check for non-initialised Entry Today, objects are always initialised, so this check is superfluous, and the get_tag_qualifier will properly handle errors from acl_* functions, so even if that invariant is actually violated, this will not lead to undefined behaviour. --- acl.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/acl.c b/acl.c index 1d74833..eb7d491 100644 --- a/acl.c +++ b/acl.c @@ -971,10 +971,6 @@ static PyObject* Entry_get_qualifier(PyObject *obj, void* arg) { unsigned long value; tag_qual tq; - if (self->entry == NULL) { - PyErr_SetString(PyExc_ValueError, "Can't get qualifier on uninitalized Entry object"); - return NULL; - } if(get_tag_qualifier(self->entry, &tq) < 0) { return NULL; } -- 2.39.2