From d425613eddc4c9b0bd5d2a069ab8a4750b0214e0 Mon Sep 17 00:00:00 2001
From: Iustin Pop <iustin@k1024.org>
Date: Wed, 27 Nov 2019 21:40:28 +0100
Subject: [PATCH] A bit more tests

---
 tests/test_acls.py | 37 ++++++++++++++++++++++++++++---------
 1 file changed, 28 insertions(+), 9 deletions(-)

diff --git a/tests/test_acls.py b/tests/test_acls.py
index 25d79fa..a07d316 100644
--- a/tests/test_acls.py
+++ b/tests/test_acls.py
@@ -52,15 +52,18 @@ PERMSETS = {
   posix1e.ACL_EXECUTE: ("execute", posix1e.Permset.execute),
   }
 
-ALL_TAG_TYPES = [
-  posix1e.ACL_USER,
-  posix1e.ACL_GROUP,
-  posix1e.ACL_USER_OBJ,
-  posix1e.ACL_GROUP_OBJ,
-  posix1e.ACL_MASK,
-  posix1e.ACL_OTHER,
+ALL_TAGS = [
+  (posix1e.ACL_USER, "user"),
+  (posix1e.ACL_GROUP, "group"),
+  (posix1e.ACL_USER_OBJ, "user object"),
+  (posix1e.ACL_GROUP_OBJ, "group object"),
+  (posix1e.ACL_MASK, "mask"),
+  (posix1e.ACL_OTHER, "other"),
 ]
 
+ALL_TAG_VALUES = [i[0] for i in ALL_TAGS]
+ALL_TAG_DESCS = [i[1] for i in ALL_TAGS]
+
 # Check if running under Python 3
 IS_PY_3K = sys.hexversion >= 0x03000000
 
@@ -704,7 +707,7 @@ class TestModification:
         with pytest.raises(TypeError):
           e.qualifier
 
-    @pytest.mark.parametrize("tag", ALL_TAG_TYPES)
+    @pytest.mark.parametrize("tag", ALL_TAG_VALUES, ids=ALL_TAG_DESCS)
     def test_tag_types(self, tag):
         """Tests tag type correct set/get"""
         acl = posix1e.ACL()
@@ -714,6 +717,19 @@ class TestModification:
         # check we can show all tag types without breaking
         assert str(e)
 
+    @pytest.mark.parametrize("src_tag", ALL_TAG_VALUES, ids=ALL_TAG_DESCS)
+    @pytest.mark.parametrize("dst_tag", ALL_TAG_VALUES, ids=ALL_TAG_DESCS)
+    def test_tag_overwrite(self, src_tag, dst_tag):
+        """Tests tag type correct set/get"""
+        acl = posix1e.ACL()
+        e = acl.append()
+        e.tag_type = src_tag
+        assert e.tag_type == src_tag
+        assert str(e)
+        e.tag_type = dst_tag
+        assert e.tag_type == dst_tag
+        assert str(e)
+
     def test_invalid_tags(self):
         """Tests tag type incorrect set/get"""
         acl = posix1e.ACL()
@@ -725,8 +741,11 @@ class TestModification:
         with pytest.raises((TypeError, AttributeError)):
           del e.tag_type
 
+    def test_tag_wrong_overwrite(self):
+        acl = posix1e.ACL()
+        e = acl.append()
         e.tag_type = posix1e.ACL_USER_OBJ
-        tag = max(ALL_TAG_TYPES) + 1
+        tag = max(ALL_TAG_VALUES) + 1
         with pytest.raises(EnvironmentError):
           e.tag_type = tag
         # Check tag is still valid.
-- 
2.39.5