pylibacl.git
16 months agoFix tests path in MANIFEST.in
Iustin Pop [Fri, 29 Nov 2019 16:22:10 +0000 (17:22 +0100)]
Fix tests path in MANIFEST.in

16 months agoAdd type: ignore to tests where we force bad behaviour
Iustin Pop [Fri, 29 Nov 2019 16:19:41 +0000 (17:19 +0100)]
Add type: ignore to tests where we force bad behaviour

16 months agoAdd trove classifiers and project urls
Iustin Pop [Fri, 29 Nov 2019 15:33:03 +0000 (16:33 +0100)]
Add trove classifiers and project urls

16 months agoAnother xfail test
Iustin Pop [Fri, 29 Nov 2019 15:32:07 +0000 (16:32 +0100)]
Another xfail test

16 months agoSimplify ACL.append to not duplicate Entry creation
Iustin Pop [Fri, 29 Nov 2019 15:08:37 +0000 (16:08 +0100)]
Simplify ACL.append to not duplicate Entry creation

Similar to the pattern for Entry.permset, this removes the duplication
with the (child object) init.

16 months agoAdd xfail test for equiv mode failures
Iustin Pop [Fri, 29 Nov 2019 14:59:51 +0000 (15:59 +0100)]
Add xfail test for equiv mode failures

Sigh, another bug in upstream library.

16 months agoRaise better error message on un-owned but valid Entry deletion
Iustin Pop [Fri, 29 Nov 2019 14:53:48 +0000 (15:53 +0100)]
Raise better error message on un-owned but valid Entry deletion

16 months agoSimplify returning None
Iustin Pop [Fri, 29 Nov 2019 14:48:27 +0000 (15:48 +0100)]
Simplify returning None

16 months agoSwitch ACL to be always-initialised
Iustin Pop [Fri, 29 Nov 2019 14:42:42 +0000 (15:42 +0100)]
Switch ACL to be always-initialised

This is the last object to change, but the semantics here are more
complex. Since the ACL doesn't have a parent, and the init signature
is complex, we can't detect "same-reinit", we allow arbitrary-reinit,
but this makes existing live entries be undefined; they might point to
a different entry in the new ACL, or not be valid, etc.

It could be possible to prevent re-init, but doing so requires
trickery which might be broken by serialisation, so let's just leave
it there and document it as such.

16 months agoApply no-unitialised-objects to Permset as well
Iustin Pop [Fri, 29 Nov 2019 14:01:41 +0000 (15:01 +0100)]
Apply no-unitialised-objects to Permset as well

This had no checks at all (Entry has one check) on attribute access.

16 months agoStop duplicating permset initialisation
Iustin Pop [Fri, 29 Nov 2019 13:54:23 +0000 (14:54 +0100)]
Stop duplicating permset initialisation

A permset can be initalised either via `__init__ ` or by getting
`parent.permset` getter. The latter duplicates the logic in the
former, which is not good as hacks into the internals of the permset.

Remove the duplication by just calling explicitly permset(self) and
returning the value of it.

16 months agoExpand acl_check testing for actual value checks
Iustin Pop [Fri, 29 Nov 2019 13:36:29 +0000 (14:36 +0100)]
Expand acl_check testing for actual value checks

This actually tests upstream, but just "assert a.check()/not
a.check()" seems too little.

16 months agoRestore setstate/getstate support
Iustin Pop [Fri, 29 Nov 2019 13:35:11 +0000 (14:35 +0100)]
Restore setstate/getstate support

Sigh, another brown-bag issue. One small typo in a place, plus a
missing macro, and this went unseen for ages.

Also add a basic test for it. Probably should add Pickle as well.

16 months agoSlightly expand the NEWS file
Iustin Pop [Fri, 29 Nov 2019 13:32:10 +0000 (14:32 +0100)]
Slightly expand the NEWS file

16 months agoChange Entry initialisation protocol
Iustin Pop [Fri, 29 Nov 2019 13:28:06 +0000 (14:28 +0100)]
Change Entry initialisation protocol

This fixes very large and significant bugs - segfaults and memory
leaks - that were present for uninitialised object, more precisely
created but not init'ed ones.

I spent quite a bit of time thinking back on forth how to fix this,
and from the two options of:

- check initialised status on all code paths, or
- don't ever allow invalid/un-initialised objects

The latter one seems the correct one, even though the Python C API
docs imply that doing actual stuff in `__new__` should be "rare".

Tests for reference leaks and wrong re-init added as well; these would
have caught at least memory leaks before.

16 months agoStandardise on capitalised error messages
Iustin Pop [Fri, 29 Nov 2019 13:20:46 +0000 (14:20 +0100)]
Standardise on capitalised error messages

For good or worse, but at least standard.

16 months agoUnify attribute deletion checks for Entry
Iustin Pop [Fri, 29 Nov 2019 13:20:11 +0000 (14:20 +0100)]
Unify attribute deletion checks for Entry

16 months agoReduce verbosity in fast-tests
Iustin Pop [Fri, 29 Nov 2019 13:14:55 +0000 (14:14 +0100)]
Reduce verbosity in fast-tests

Otherwise compilation issues are missed.

16 months agoCleanup py2-compatibility 'except' syntax
Iustin Pop [Fri, 29 Nov 2019 03:11:43 +0000 (04:11 +0100)]
Cleanup py2-compatibility 'except' syntax

16 months agoRemove tests/__init__.py as not needed with pytest
Iustin Pop [Fri, 29 Nov 2019 02:52:23 +0000 (03:52 +0100)]
Remove tests/__init__.py as not needed with pytest

16 months agoInclude filename in exceptions raised in delete_default
Iustin Pop [Fri, 29 Nov 2019 01:20:58 +0000 (02:20 +0100)]
Include filename in exceptions raised in delete_default

And add test for failure.

16 months agoAdd tests for a few IO failures
Iustin Pop [Wed, 27 Nov 2019 22:20:57 +0000 (23:20 +0100)]
Add tests for a few IO failures

Marginal test coverage increase, but checks that we do raise IOError
as expected.

16 months agoAdd pathlib support in apply_to and has_extended
Iustin Pop [Wed, 27 Nov 2019 22:04:05 +0000 (23:04 +0100)]
Add pathlib support in apply_to and has_extended

This is done by switching these functions to PyUnicode_FSConverter,
thus removing a chunk of custom, and probably buggy, code. Easier to
read as well…

16 months agoAdd more test infrastructure for parameterisation
Iustin Pop [Wed, 27 Nov 2019 21:30:20 +0000 (22:30 +0100)]
Add more test infrastructure for parameterisation

Not sure how much will be used yet…

16 months agoPy3 cleanup for the module itself
Iustin Pop [Wed, 27 Nov 2019 21:01:24 +0000 (22:01 +0100)]
Py3 cleanup for the module itself

16 months agoAdd no external to coverage target
Iustin Pop [Wed, 27 Nov 2019 20:52:41 +0000 (21:52 +0100)]
Add no external to coverage target

16 months agotests: Py3 cleanup
Iustin Pop [Wed, 27 Nov 2019 20:41:45 +0000 (21:41 +0100)]
tests: Py3 cleanup

16 months agoA bit more tests
Iustin Pop [Wed, 27 Nov 2019 20:40:28 +0000 (21:40 +0100)]
A bit more tests

16 months agoConvert TestModification to pytest
Iustin Pop [Wed, 27 Nov 2019 20:33:23 +0000 (21:33 +0100)]
Convert TestModification to pytest

And that was the last one…

16 months agoOne more makefile test target
Iustin Pop [Wed, 27 Nov 2019 20:32:17 +0000 (21:32 +0100)]
One more makefile test target

16 months agoStop testing with pypy2
Iustin Pop [Wed, 27 Nov 2019 08:39:56 +0000 (09:39 +0100)]
Stop testing with pypy2

Broken already :)

16 months agoStandardise skip-on-pypy decorator
Iustin Pop [Wed, 27 Nov 2019 08:35:36 +0000 (09:35 +0100)]
Standardise skip-on-pypy decorator

16 months agoConvert AclExtensions to pytest
Iustin Pop [Tue, 26 Nov 2019 23:22:07 +0000 (00:22 +0100)]
Convert AclExtensions to pytest

16 months agoConvert WriteTests to pytest
Iustin Pop [Tue, 26 Nov 2019 22:54:51 +0000 (23:54 +0100)]
Convert WriteTests to pytest

16 months agoSwitch LoadTests to pytest
Iustin Pop [Tue, 26 Nov 2019 22:50:25 +0000 (23:50 +0100)]
Switch LoadTests to pytest

16 months agotests: add helper functions/fixtures
Iustin Pop [Tue, 26 Nov 2019 22:42:32 +0000 (23:42 +0100)]
tests: add helper functions/fixtures

16 months agoSwitch travis to pytest as well
Iustin Pop [Tue, 26 Nov 2019 22:57:49 +0000 (23:57 +0100)]
Switch travis to pytest as well

16 months agoSwitch to running tests via pytest
Iustin Pop [Tue, 26 Nov 2019 22:41:42 +0000 (23:41 +0100)]
Switch to running tests via pytest

This doesn't change the test code, just the runner (for now).

16 months agoStop supporting Python 2
Iustin Pop [Tue, 26 Nov 2019 22:40:16 +0000 (23:40 +0100)]
Stop supporting Python 2

This just changes the documentation and stop testing with Python
2. Future patches will actually drop compatibility.

16 months agoAdd a fast-test target
Iustin Pop [Tue, 26 Nov 2019 21:42:51 +0000 (22:42 +0100)]
Add a fast-test target

16 months agoRename test/ → tests/
Iustin Pop [Tue, 26 Nov 2019 21:41:20 +0000 (22:41 +0100)]
Rename test/ → tests/

More consistency between my packages.

16 months agoRun local tests with 3.8 as well
Iustin Pop [Tue, 26 Nov 2019 21:23:10 +0000 (22:23 +0100)]
Run local tests with 3.8 as well

16 months agoAdd a distcheck target
Iustin Pop [Tue, 26 Nov 2019 21:22:51 +0000 (22:22 +0100)]
Add a distcheck target

16 months agoTravis: test python 3.7 and 3.8 in standard way
Iustin Pop [Sun, 24 Nov 2019 14:39:25 +0000 (15:39 +0100)]
Travis: test python 3.7 and 3.8 in standard way

This removes the hack for python 3.7, and add 3.8 as well.

16 months agoExport coverage results to codecov as well
Iustin Pop [Sun, 24 Nov 2019 14:36:29 +0000 (15:36 +0100)]
Export coverage results to codecov as well

And also move the env var to just the coveralls invocation.

16 months agoBadge-ify the README
Iustin Pop [Sat, 23 Nov 2019 00:14:37 +0000 (01:14 +0100)]
Badge-ify the README

Hey, it's fun!

16 months agoUpdate Travis config to export coverage information
Iustin Pop [Fri, 22 Nov 2019 21:39:22 +0000 (22:39 +0100)]
Update Travis config to export coverage information

17 months agoBump version numbers for new release pylibacl-v0.5.4
Iustin Pop [Thu, 14 Nov 2019 10:58:42 +0000 (11:58 +0100)]
Bump version numbers for new release

Only 4+ years…

17 months agoNote that ACL(text="...") needs a valid ACL to be passed
Iustin Pop [Thu, 14 Nov 2019 10:45:26 +0000 (11:45 +0100)]
Note that ACL(text="...") needs a valid ACL to be passed

Closes #9.

17 months agoEnsure documentation is rebuilt on source (.c) changes
Iustin Pop [Thu, 14 Nov 2019 10:38:27 +0000 (11:38 +0100)]
Ensure documentation is rebuilt on source (.c) changes

17 months agoUpdate FreeBSD notes
Iustin Pop [Thu, 14 Nov 2019 10:27:17 +0000 (11:27 +0100)]
Update FreeBSD notes

This mentions needing to enable ACLs on the file-system, and adds the
packages that need to be installed.

Closes #12.

17 months agoUpdate README about build requirements
Iustin Pop [Wed, 13 Nov 2019 23:23:27 +0000 (00:23 +0100)]
Update README about build requirements

17 months agoMakefile: stop trying to test with py<2.7
Iustin Pop [Wed, 13 Nov 2019 23:16:46 +0000 (00:16 +0100)]
Makefile: stop trying to test with py<2.7

Since actual compat was removed a while back.

17 months agoSwitch documentation building to Python 3
Iustin Pop [Wed, 13 Nov 2019 23:14:24 +0000 (00:14 +0100)]
Switch documentation building to Python 3

This removes build-time dependency on Python 2, which is going away.

18 months agoTravis: remove obsolete python version
Iustin Pop [Sun, 13 Oct 2019 15:55:53 +0000 (17:55 +0200)]
Travis: remove obsolete python version

Some of them, at least.

2 years agoMakefile: re-enable pypy and add pypy3
Iustin Pop [Sun, 3 Mar 2019 12:56:58 +0000 (13:56 +0100)]
Makefile: re-enable pypy and add pypy3

Everything works again now, so let's enable them.

2 years agoACL creation: change how mode arguments are used
Iustin Pop [Sun, 3 Mar 2019 12:45:45 +0000 (13:45 +0100)]
ACL creation: change how mode arguments are used

Currently, initialising from a mode is done by looking at the keywords
arguments that were passed and seeing if mode was part of them. For
some reason, this causes a segfault under PyPy (my fault, probably),
so let's switch to check based on whether the mode argument was
initialised. To do so, switch the type of mode to int and the Python
format char, since the 'H' is defined as "without overflow checking"
anyway, so we don't get any real checks. Document that invalid values
will cause errors.

2 years agoRemove use of PyString/PyUnicode *AndDel() function
Iustin Pop [Sun, 3 Mar 2019 12:42:10 +0000 (13:42 +0100)]
Remove use of PyString/PyUnicode *AndDel() function

These are not documented in Python 3, so let's switch to plain
Concat() for it with explicit delete of original strings. This makes
the code buildable with pypy3.

2 years agoTravis: really test 3.7
Iustin Pop [Sun, 3 Mar 2019 12:22:40 +0000 (13:22 +0100)]
Travis: really test 3.7

This version seems to work. Sigh…

2 years agoTravis: more reworking of Py3.7 support…
Iustin Pop [Sun, 3 Mar 2019 12:02:31 +0000 (13:02 +0100)]
Travis: more reworking of Py3.7 support…

2 years agoTravis: rework build matrix
Iustin Pop [Sun, 3 Mar 2019 11:58:40 +0000 (12:58 +0100)]
Travis: rework build matrix

Apparently python 3.7 is not available on the default Trusty
distribution, so let's add Xenial for the newer Python versions. More
builds!

2 years agoDrop Python 2.6 and earlier support
Iustin Pop [Sun, 3 Mar 2019 11:47:36 +0000 (12:47 +0100)]
Drop Python 2.6 and earlier support

While the C extension doesn't need anything to support it, simply
running the tests becomes more and more difficult with such old
versions. Given upcoming Python 2 deprecation, let's drop support for
older versions and simplify the test suite.

2 years agoDisable pypy tests in Makefile
Iustin Pop [Sun, 3 Mar 2019 01:40:56 +0000 (02:40 +0100)]
Disable pypy tests in Makefile

With my current pypy, ACL_init triggers a SEGFAULT in pypy. Until I
can debug what's up, let's remove this test.

2 years agoIncrease test coverage
Iustin Pop [Sun, 3 Mar 2019 01:40:04 +0000 (02:40 +0100)]
Increase test coverage

These are old changes from October 2016 which I forgot to commit. I
think they're related to test coverage, although a few changes (object
structure) seems a bit different.

Well, anyway, here they are.

2 years agoTravis: add python 3.5/3.6 to build matrix
Iustin Pop [Sat, 2 Mar 2019 20:16:52 +0000 (21:16 +0100)]
Travis: add python 3.5/3.6 to build matrix

2 years agoTravis: remove "sudo:false"
Iustin Pop [Sat, 2 Mar 2019 20:09:30 +0000 (21:09 +0100)]
Travis: remove "sudo:false"

Per the deprecation of container-based
builds (https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration),
remove the sudo:false setting.

4 years agoAdd a makefile coverage target
Iustin Pop [Wed, 26 Oct 2016 16:11:35 +0000 (18:11 +0200)]
Add a makefile coverage target

… which says that current test coverage is pretty bad - 55% line-based
and only 67% functions :(

4 years agoAlso run tests with debug interpreters
Iustin Pop [Sun, 15 May 2016 03:18:37 +0000 (05:18 +0200)]
Also run tests with debug interpreters

And bump up Python 3.x versions.

4 years agoAdd travis config file
Iustin Pop [Mon, 2 May 2016 21:07:14 +0000 (23:07 +0200)]
Add travis config file

This can be done now that travis environment has whitelisted the
libacl1-dev package.

5 years agoInvert get_tag_qualifier() return value meaning
Iustin Pop [Fri, 1 May 2015 21:12:23 +0000 (23:12 +0200)]
Invert get_tag_qualifier() return value meaning

Returning negative value on error (rather than zero) makes the
function more friendly for cpychecker, and allows the code to be
cpychecker clean.

5 years agoAdd cpychecker macro for exception negative results
Iustin Pop [Fri, 1 May 2015 20:29:54 +0000 (22:29 +0200)]
Add cpychecker macro for exception negative results

Per http://gcc-python-plugin.readthedocs.org/en/latest/cpychecker.html#errors-in-exception-handling.

5 years agoAdd cpychecker annotations for type/object correspondence
Iustin Pop [Fri, 1 May 2015 20:11:22 +0000 (22:11 +0200)]
Add cpychecker annotations for type/object correspondence

Per http://gcc-python-plugin.readthedocs.org/en/latest/cpychecker.html#associating-pytypeobject-instances-with-compile-time-types.

5 years agoBump copyright years
Iustin Pop [Fri, 1 May 2015 20:11:15 +0000 (22:11 +0200)]
Bump copyright years

5 years agoRename README→README.rst
Iustin Pop [Fri, 1 May 2015 19:58:21 +0000 (21:58 +0200)]
Rename README→README.rst

This should give better formatting, e.g. in github project page.

5 years agoAdd the release date to NEWS files entries
Iustin Pop [Fri, 1 May 2015 19:56:20 +0000 (21:56 +0200)]
Add the release date to NEWS files entries

5 years agoBump version for 0.5.3 release pylibacl-v0.5.3
Iustin Pop [Thu, 30 Apr 2015 20:20:17 +0000 (22:20 +0200)]
Bump version for 0.5.3 release

5 years agoUpdate my email address
Iustin Pop [Thu, 30 Apr 2015 20:14:56 +0000 (22:14 +0200)]
Update my email address

5 years agoSmall style change in setup.py
Iustin Pop [Thu, 30 Apr 2015 20:13:54 +0000 (22:13 +0200)]
Small style change in setup.py

5 years agoMerge remote-tracking branch 'github/master'
Iustin Pop [Thu, 30 Apr 2015 20:12:53 +0000 (22:12 +0200)]
Merge remote-tracking branch 'github/master'

Merge pull request made on GitHub.

5 years agoCleanup all .so files on 'make clean'
Iustin Pop [Thu, 30 Apr 2015 20:11:32 +0000 (22:11 +0200)]
Cleanup all .so files on 'make clean'

Otherwise 'make test' can result in very weird error messages, if
hitting https://bugs.python.org/issue7559 (don't ask…).

5 years agotests: ignore IOErrors during operations invalid ACLs
Iustin Pop [Thu, 30 Apr 2015 17:48:41 +0000 (19:48 +0200)]
tests: ignore IOErrors during operations invalid ACLs

It seems that FreeBSD at least returns EINVAL from calc_mask() and
other calls if the ACL is invalid, so let's ignore such IOErrors.

This should hopefully fix #6 and #7.

5 years agoMerge pull request #8 from yaneurabeya/master
Iustin Pop [Thu, 30 Apr 2015 18:41:33 +0000 (20:41 +0200)]
Merge pull request #8 from yaneurabeya/master

Handle FreeBSD versions greater than or equal to 7.x

5 years agotests: don't call acl_to_text on an invalid ACL
Iustin Pop [Thu, 30 Apr 2015 17:43:53 +0000 (19:43 +0200)]
tests: don't call acl_to_text on an invalid ACL

While Linux is happy to convert it to text, it seems that under
FreeBSD this doesn't (always? sometimes?) work, so let's use a proper
ACL in the str() test.

Closes #5.

6 years agoHandle FreeBSD versions greater than or equal to 7.x
Garrett Cooper [Wed, 27 Aug 2014 08:14:30 +0000 (01:14 -0700)]
Handle FreeBSD versions greater than or equal to 7.x

Sponsored by: EMC / Isilon Storage Division

6 years agoSimplify a bit the module initialization
Iustin Pop [Sat, 28 Jun 2014 20:35:32 +0000 (22:35 +0200)]
Simplify a bit the module initialization

A few constants are more nicely defined.

6 years agoTry to fix uid_t/gid_t usage in entry qualifiers
Iustin Pop [Sat, 28 Jun 2014 12:13:32 +0000 (14:13 +0200)]
Try to fix uid_t/gid_t usage in entry qualifiers

The current code is very broken with regards to the casting between
Python's integer type (either int in Py2 or the magic int/long in Py3)
and the uid_t/gid_t POSIX types. This means that the code is broken
outside "small" integer values.

By using uid_t/gid_t as appropriate, we can fix most of the problem
(at least as far as the new unittests are concerned). There's still no
automatic printf format modifier for them, so the code hardcodes
unsigned (which is what Linux/glibc defines them to), and also there's
a unittest that expects negative values to fail when set.

This should fix issue #3 (github).

6 years agoFirst step towards fixing qualifier overflow
Iustin Pop [Tue, 24 Jun 2014 21:23:12 +0000 (23:23 +0200)]
First step towards fixing qualifier overflow

This is still a work-in-progress, since it only deals with
Python-level overflows, but it's a step forward.

6 years agoFix error message in Entry_set_qualifier
Iustin Pop [Tue, 24 Jun 2014 19:51:29 +0000 (21:51 +0200)]
Fix error message in Entry_set_qualifier

This closes #1 (github issue).

6 years agoFix download link in README
Iustin Pop [Fri, 23 May 2014 22:57:40 +0000 (00:57 +0200)]
Fix download link in README

… since github no longer provides downloads.

6 years agoAdd a 'dist' target pylibacl-v0.5.2
Iustin Pop [Fri, 23 May 2014 22:41:59 +0000 (00:41 +0200)]
Add a 'dist' target

6 years agoBump version for a trivial 0.5.2 release
Iustin Pop [Fri, 23 May 2014 22:40:07 +0000 (00:40 +0200)]
Bump version for a trivial 0.5.2 release

6 years agoFix some indentation issues in tests
Iustin Pop [Fri, 23 May 2014 22:37:13 +0000 (00:37 +0200)]
Fix some indentation issues in tests

6 years agoFix homepage URL
Iustin Pop [Fri, 23 May 2014 22:36:58 +0000 (00:36 +0200)]
Fix homepage URL

6 years agoFix copyright years and intent to (not) test Solaris
Iustin Pop [Fri, 23 May 2014 22:36:37 +0000 (00:36 +0200)]
Fix copyright years and intent to (not) test Solaris

6 years agoUnify env and python variable TEST_DIR
Iustin Pop [Fri, 23 May 2014 22:22:13 +0000 (00:22 +0200)]
Unify env and python variable TEST_DIR

The difference is just confusing.

6 years agoEnable testing on more Python versions and PyPy
Iustin Pop [Fri, 23 May 2014 22:20:58 +0000 (00:20 +0200)]
Enable testing on more Python versions and PyPy

… except for the refcount test which doesn't work (and makes no sense)
under PyPy as it has a non-reference count model).

8 years agoRename tests → test and distribute test files too
Iustin Pop [Thu, 17 May 2012 02:49:37 +0000 (04:49 +0200)]
Rename tests → test and distribute test files too

The rename is done for consistency with other projects, and
distributing the tests is of course useful.

8 years agoFix manifest file after reorganisations
Iustin Pop [Thu, 17 May 2012 02:48:12 +0000 (04:48 +0200)]
Fix manifest file after reorganisations

Forgot this after the doc changes…

8 years agoUpdate NEWS and bump version number for 0.5.1 release pylibacl-v0.5.1
Iustin Pop [Sun, 13 May 2012 04:14:57 +0000 (06:14 +0200)]
Update NEWS and bump version number for 0.5.1 release

8 years agoExpand the range of Python versions for unittests
Iustin Pop [Sun, 13 May 2012 04:13:11 +0000 (06:13 +0200)]
Expand the range of Python versions for unittests

3.3 has some issues (refuses to recognise 'test-suite') on my machine,
not yet enabled.